Make stuff work more easily on Linux/ROCm #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Interesting... I suppose that was naive of me to not expect people to need to customize environment variables for their GPU. I feel like there was a reason I wanted to isolate the Demucs process from the rest of the system environment variables (which are kind of messy on Windows) but I'm not sure that my concern was actually valid. I'm hesitant to push out a new release and notify everyone to download 1-2GB update for this change only, but I'll merge this PR in on the next release. Thank you so much for submitting this, and I'm happy to hear it's working now on your ROCm Linux device! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With my relatively new AMD Radeon RX 7800 XT I need to set the following envvars for ROCm to work:
Instead of hardcoding this all, just pass the whole parent environment in, this is the default behaviour anyway for most "spawn" APIs.
Also
torchaudiocan't detect my ffmpeg 7, it seems to not support this yet.libsox-devworks as an alternative.Now I can demux stems in 20 seconds compared to 10 minutes for Wine/CPU! :D